Report any technical problems you discover and discuss solutions.

v3: Issue: Management buttons overlapping

jayaich
Auteur du sujet
Hors Ligne
Membre premium

Plus d'informations

il y a 10 ans 11 mois #2992 par jayaich

v3: Issue: Management buttons overlapping a été créé par jayaich

Hello,

I'm marking this as an issue since it relates to a style problem and so may well just be my browser being silly!

If I access the management web page (/management.php), and log in, then I get the button layout shown in attachment one (hopefully!).

The logout button is, in effect, interfering with our site logo, and there seem to be too many middle buttons for the width of the window. Hence the last ones seem to overlap and displace each other.
I am using Firefox 39, but the problem also happens with IE11. With Chrome it looks better, but the logout button is still a problem.

To try and resolve this I have made two changes:
1) Increase the width of the window from 910px to 935px. I also removed the right border setting, and slightly adjusted part of the padding.
2) Move the logout button next to the save button.

I've attached the changes, and an image of the new layout.

John.

Fichier attaché :

Nom du fichier : management.css
Taille du ficher :1 Ko

Pièces jointes :

Connexion ou Créer un compte pour participer à la conversation.

jayaich
Auteur du sujet
Hors Ligne
Membre premium

Plus d'informations

il y a 10 ans 11 mois #2993 par jayaich

Réponse de jayaich sur le sujet v3: Issue: Management buttons overlapping

Hurrah! The attachments mostly worked. It seems to have left one attachment off. There should be an attachment patch for 'management.php'. I'll attach it here.

John.

Connexion ou Créer un compte pour participer à la conversation.

jayaich
Auteur du sujet
Hors Ligne
Membre premium

Plus d'informations

il y a 10 ans 11 mois #2994 par jayaich

Réponse de jayaich sur le sujet v3: Issue: Management buttons overlapping

Ah. It obviously doesn't like PHP. Here's the change inline:

Code:

--- management.php.orig 2015-07-29 23:17:23.000000000 +0100
+++ management.php      2015-08-11 12:18:22.615990303 +0100
@@ -235,7 +235,6 @@
                         ?>
                         <div
                             style="width:50%; height:100%; float:right; position:relative; background-image:url(<?php echo "branding/logo_right.png";?>); background-repeat:no-repeat; background-position:right; margin-right:10px; float:right">
-                            <p style="float:right; margin:0px; color:#a01a13;"><button type="button" class="xerte_button" onclick="javascript:logout()" ><i class="fa fa-sign-out"></i> <?PHP echo MANAGEMENT_LOGOUT; ?></button></p>
                         </div>
                         <?php
                     }
@@ -243,7 +242,6 @@
                         ?>
                         <div
                             style="width:50%; height:100%; float:right; position:relative; background-image:url(website_code/images/apereoLogo.png); background-repeat:no-repeat; background-position:right; margin-right:10px; float:right">
-                            <p style="float:right; margin:0px; color:#a01a13;"><button type="button" class="xerte_button" onclick="javascript:logout()" ><i class="fa fa-sign-out"></i> <?PHP echo MANAGEMENT_LOGOUT; ?></button></p>
                         </div>
                         <?php
                     }
@@ -303,6 +301,7 @@
                                 </div>
                                 <div class="admin_mgt_area_middle_button_right">
                                     <button type="button" class="xerte_button" onclick="javascript:save_changes()"><i class="fa fa-floppy-o"></i> <?PHP echo MANAGEMENT_MENUBAR_SAVE; ?></button>
+                                    <button type="button" class="xerte_button" onclick="javascript:logout()" ><i class="fa fa-sign-out"></i> <?PHP echo MANAGEMENT_LOGOUT; ?></button>
                                 </div>
                                 <div id="admin_area">
                                 </div>

John.

Connexion ou Créer un compte pour participer à la conversation.

julten
Hors Ligne
Modérateur

Plus d'informations

il y a 10 ans 11 mois #2998 par julten

Réponse de julten sur le sujet v3: Issue: Management buttons overlapping

I'm not sure from that how to apply the changes... (my git ignorance...). I have done the css one.

Connexion ou Créer un compte pour participer à la conversation.

jayaich
Auteur du sujet
Hors Ligne
Membre premium

Plus d'informations

il y a 10 ans 11 mois #3007 par jayaich

Réponse de jayaich sur le sujet v3: Issue: Management buttons overlapping

I am a bit confused as to why your confused :-)

If you applied the CSS changes, then surely you just do the same but with the PHP changes. Since the change is just removing two lines and inserting one (albeit all in different places), I would have either copy/paste the patch provided into a local file and then apply that to your local git clone. Or, since they are just one line changes, apply them directly to the source code in the development git branch on github. It depends on how you use git, and how the project uses git branches.

John.

Connexion ou Créer un compte pour participer à la conversation.

julten
Hors Ligne
Modérateur

Plus d'informations

il y a 10 ans 11 mois #3008 par julten

Réponse de julten sur le sujet v3: Issue: Management buttons overlapping

OK, so I took the inline text, saved it as a .patch file and then trried to apply it using tortoise git. It fails with 'unable to detecxt path format' or some such. This is due to my inexperience with git, so if you have any guidnace as to how to proceed, it would be welcome.

Connexion ou Créer un compte pour participer à la conversation.

Modérateurs: ronm, julten, JohnSmith

Temps de génération de la page : 0.156 secondes

Propulsé par Kunena

v3: Issue: Management buttons overlapping

Fichier attaché :

Main Pages

Quick Links

Support

External resources