Supporting each other

Community forums

Welcome, Guest
Username: Password: Remember me
Report any technical problems you discover and discuss solutions.

TOPIC:

expand youtube video to full screen 9 years 1 month ago #3219

  • ronm
  • ronm's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 852
  • Thank you received: 261
Yes the checking not false rather than equal to true option didn't seem to be working either so either comment out or probably just remove the condition e.g.

//if (iframe.allowfullscreen != false) { --delete this line
html += " allowfullscreen";
//} - and delete this line
Then possibly clear cache/offline files before refreshing and trying again.
HTH
Ron
Xerte developer & trainer
e-learning & m-learning consultant
mitchellmedia.co.uk | xerteacademy.com | learningapps.co.uk
Note: Support here is voluntary and meant for users to support each other.
Need direct commercial support with Xerte? mitchellmedia.co.uk/contact/

Please Log in or Create an account to join the conversation.

expand youtube video to full screen 9 years 1 month ago #3221

  • julten
  • julten's Avatar
  • Offline
  • Moderator
  • Moderator
  • Posts: 137
  • Thank you received: 18
Is here any reason we should not remove the condition?
Maybe it is checking for strings rather than booleans?

Please Log in or Create an account to join the conversation.

expand youtube video to full screen 9 years 1 month ago #3223

  • julten
  • julten's Avatar
  • Offline
  • Moderator
  • Moderator
  • Posts: 137
  • Thank you received: 18
Well, I cannot think of a good reason not to allow the control to be there: it's up to the user whether or not they use it which is in-keeping with our 'put the user in control' principle; it's good on tablets / phones and it's just generally good accessibility-wise. I don't know whether youtube users can choose to disable this when a movie is published, but ultimately surely it's up to the end-user whether they use it or not?

I've commited a change, and removed the condition.
The following user(s) said Thank You: 0kee

Please Log in or Create an account to join the conversation.

Moderators: ronmjultenJohnSmith
Time to create page: 0.046 seconds
Copyright © 2024 The Xerte Project.
Xerte logo Apereo logo OSI Logo

Search