Supporting each other

Community forums

Welcome, Guest
Username: Password: Remember me
Report any technical problems you discover and discuss solutions.
  • Page:
  • 1
  • 2

TOPIC:

V3 beta: Organisational logo not on login page 9 years 4 months ago #2920

  • jayaich
  • jayaich's Avatar Topic Author
  • Offline
  • Premium Member
  • Premium Member
  • Posts: 82
  • Thank you received: 5
Hello,

Using 3.0 we configured our site logo (image) for use with Xerte. The logo didn't appear on the login page, but did appear once logged in. The image was put into the 'branding' directory as 'logo_right.png'.
The browser console showed the problem to be an incorrect URL. In our case:

http://.../var/www/html/xerte/branding/logo_right.png [HTTP/1.1 404 Not Found 1ms]

Looking at the file 'website_code/php/login_library.php' shows that both the left and right logos are checked for existence, and then tried to be loaded with the full disk pathname. This obviously fails.

I have attached a patch for this which worked for us.

Please Inloggen or Create an account to join the conversation.

V3 beta: Organisational logo not on login page 9 years 4 months ago #2923

  • jayaich
  • jayaich's Avatar Topic Author
  • Offline
  • Premium Member
  • Premium Member
  • Posts: 82
  • Thank you received: 5
Hmm, seems the patch wasn't attached. Second time round...

Please Inloggen or Create an account to join the conversation.

V3 beta: Organisational logo not on login page 9 years 4 months ago #2924

  • jayaich
  • jayaich's Avatar Topic Author
  • Offline
  • Premium Member
  • Premium Member
  • Posts: 82
  • Thank you received: 5
Nope, it just doesn't seem to like attachments. So here it is inline:
--- login_library.php.orig      2015-07-17 21:25:07.000000000 +0100
+++ login_library.php   2015-07-22 14:00:52.307272855 +0100
@@ -222,7 +222,7 @@
     {
         ?>
         <div
-            style="width:50%; height:100%; float:right; position:relative; background-image:url(<?php echo $xerte_toolkits_site->root_file_path . "branding/logo_right.png";?>); background-repeat:no-repeat; background-position:right; margin-right:10px; float:right">
+            style="width:50%; height:100%; float:right; position:relative; background-image:url(branding/logo_right.png); background-repeat:no-repeat; background-position:right; margin-right:10px; float:right">
         </div>
     <?php
     }
@@ -236,7 +236,7 @@
     if (file_exists($xerte_toolkits_site->root_file_path . "branding/logo_left.png"))
     {
         ?>
-        <img src="<?php echo $xerte_toolkits_site->root_file_path . "branding/logo_left.png";?>" style="margin-left:10px; float:left"/>
+        <img src="branding/logo_left.png" style="margin-left:10px; float:left"/>
     <?php
     }
     else {

Please Inloggen or Create an account to join the conversation.

V3 beta: Organisational logo not on login page 9 years 4 months ago #2925

  • ronm
  • ronm's Avatar
  • Offline
  • Administrator
  • Administrator
  • Posts: 852
  • Thank you received: 261
Thanks for sharing this. The fix is now committed.
Have you also subscribed to our dev list? lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
We're always keen for additional developers to get involved.
Regards
Ron
Xerte developer & trainer
e-learning & m-learning consultant
mitchellmedia.co.uk | xerteacademy.com | learningapps.co.uk
Note: Support here is voluntary and meant for users to support each other.
Need direct commercial support with Xerte? mitchellmedia.co.uk/contact/
The following user(s) said Thank You: jayaich

Please Inloggen or Create an account to join the conversation.

V3 beta: Organisational logo not on login page 9 years 4 months ago #2926

  • jayaich
  • jayaich's Avatar Topic Author
  • Offline
  • Premium Member
  • Premium Member
  • Posts: 82
  • Thank you received: 5

Ron Mitchell wrote: Have you also subscribed to our dev list? lists.nottingham.ac.uk/mailman/listinfo/xerte-dev
We're always keen for additional developers to get involved.

Well thanks for that, but I'm not really a developer as such but an aged sysadmin :-) However, if I find a bug, then I usually try and sort it out if possible (and pass the fix on).


John.

Please Inloggen or Create an account to join the conversation.

V3 beta: Organisational logo not on login page 9 years 4 months ago #2929

  • jayaich
  • jayaich's Avatar Topic Author
  • Offline
  • Premium Member
  • Premium Member
  • Posts: 82
  • Thank you received: 5
There were two parts to this bug and fix - one for the 'logo_right' and one for 'logo_left'. It seems that only the 'logo_left' has been fixed in github.

Please Inloggen or Create an account to join the conversation.

  • Page:
  • 1
  • 2
Moderators: ronmjultenJohnSmith
Time to create page: 0.053 seconds
Copyright © 2024 The Xerte Project.
Xerte logo Apereo logo OSI Logo

Search